add asset api support #1062
Open
add asset api support #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add block height check when run transaction * finetune the config height * update blockheight, estimate by ((two weeks block) * 2 + current blockheight) * make pickitem support both big.int and bytearray. ensure big.int do not expose to user * update opcode hight constant to future block
* fix Vbft Block serdes * enforce merkleRoot data in Block msg * fix error handlings
* add repeat tx check in p2p * add lru cache to save tx in Link * gofmt * move duplicate tx check to TransactionHandle * fix checkDuplicateTx bug * go fmt * change printf fmt * change txCache init * refactor code * change store tx to store txhash
* make no mask if addr request is from masked peers * update addr-req testcase
* update neovm new opecode height restriction * fixed testnet neovm opcode height
* add go.mod * add golang.org/x/text and tools * update travis for gomod * fix .travis.yml, build image firstly * add GO111MODULE to travis config * format peer_pool.go with gofmt v1.12.x * remove .travis script test on windows
* add check block height for pickitem opcode * move block strict to neovm engine structure
| @@ -104,6 +104,7 @@ var ( | |||
| RUNTIME_ADDRESSTOBASE58_NAME = "Ontology.Runtime.AddressToBase58" | |||
| RUNTIME_GETCURRENTBLOCKHASH_NAME = "Ontology.Runtime.GetCurrentBlockHash" | |||
| RUNTIME_VERIFYMUTISIG_NAME = "Ontology.Runtime.VerifyMutiSig" | |||
| RUNTIME_ASSERT_NAME = "Ontology.Runtime.Assert" | |||
There was a problem hiding this comment.
Assert api maybe confused with the python original keyword "assert". suguest OntAssert
|
breaking change need add effective height check for testnet and mainnet. |
|
it's unnecessary to do that. it doesn't a function which has existed. |
|
I am afraid not, if compiler is ready, someone can deploy the code to testnet and mainnet at any time. |
|
the compiler won't publish this function until this function has been launched on testnet and mainnet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.